Improve StorageInterface, add method get
#660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- specifically for retrieving a single item from storage, without deep file traversal or requiring any iterables - default impl uses `at` underneath to implement it - update code in core to use it where suitable - also correct image servlet to only query for instances to DIM providers if specified
- Fix example code in #at - Clarify in #list that a trailing forward slash means that it's a directory
bastiao
approved these changes
Jul 29, 2023
|
@bastiao Since the next Dicoogle version is intended to be a patch version, let's keep this PR on hold until we plan to deploy a feature release. |
Enet4
commented
May 24, 2024
tiberio-baptista
approved these changes
Jun 13, 2024
|
@bastiao Next version of Dicoogle should be 3.4.0, so we're ready to start merging this and the other ones in the milestone: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a backwards-compatible extension to
StorageInterfacewith default methodget. Unlikeat,getis designed to retrieve up to a single item in storage, so it does not need file system tree traversal or building up iterables and iterators.A default implementation is provided that uses
atunderneath, but implementors may wish to override it for more efficiency.This PR also includes a few quality-of-life improvements, including some clarifications to other methods in the plugin interface.
Summary
StorageInterface#get, to retrieve a single item from storageatlistthat a trailing forward slash means that it's a directory